Fix sidebar for spaces on 'Shared via link'-page #9023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
|
Ehh okay, so this may be irrelevant because spaces can no longer have public links (?): owncloud/ocis#6278. Converting into draft for now. |
|
It seems that spaces will continue to support public links (see cs3org/reva#3890), hence this PR is valid and ready for review. |
AlexAndBear
approved these changes
May 31, 2023
delete-merged-branch
bot
deleted the
fix-sidebar-for-spaces-on-share-via-link
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the sidebar for spaces on the "Shared via link"-page which acted like the space was a folder resource before. I also decided to hide the actions panel for spaces in this view because the actions don't have any visible impact anyways here.
Related Issue
Types of changes