[full-ci] fix: search syntax when combining filters #9096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the search syntax when combining multiple filters together with the search term. For now, only one tag can be selected in the filter due to a server restriction. Also updates the `ItemFilter` component to properly display single-select filters.
JammingBen
force-pushed
the
fix-search-syntax
branch
from
97fa115
to
52636d5
Compare
|
Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35987/47/1 |
JammingBen
changed the title
Skip all search acceptance tests for oC10 because the search is currently broken with it.
JammingBen
force-pushed
the
fix-search-syntax
branch
from
fbd0068
to
7a2bf34
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the search syntax when combining multiple filters together with the search term. For now, only one tag can be selected in the filter due to a server restriction. Also updates the
ItemFiltercomponent to properly display single-select filters.This is a follow-up for the most recent search filter PRs.
Note that the PR breaks the search for oC10, see here for more detail: owncloud/ocis#6378 (comment)
Screenshots
Types of changes