Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Port refactor PRs #9103

Merged
merged 2 commits into from May 25, 2023
Merged

[tests-only] Port refactor PRs #9103

merged 2 commits into from May 25, 2023

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented May 25, 2023 •
edited

@saw-jan
fix expect().toBe() usage (#9093)
7dcf65e
@saw-jan
[tests-only] Refactor: remove unnecessary async and use import all (#…
82dd638 
…9089)

* fix eslint warnings

* import all as PO: pageObject

* import all as PO: pageObject

* import all as PO: pageObject

* remove unnecessary await

* user lowercase naming

* cleanup
@saw-jan saw-jan self-assigned this May 25, 2023
SwikritiT
SwikritiT approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is also haapy

@sonarcloud
Copy link

sonarcloud bot commented May 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit 1db4835 into master May 25, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the port/refactor-prs branch May 25, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT approved these changes

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put correct value in expect().toBe() function in test code
2 participants
@saw-jan @SwikritiT