fix: share indicator loading after pasting resources #9110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
reviewed
May 25, 2023
| context.commit('UPSERT_RESOURCES', fetchedResources) | ||
| context.commit('LOAD_INDICATORS', currentFolder.path) |
There was a problem hiding this comment.
is it possible that the currentFolder var can be nullish?
There was a problem hiding this comment.
I thought about it, but I don't see a scenario where we don't have a folder to paste into. Do you?
There was a problem hiding this comment.
True. And now that I looked at it in detail - the currentFolder is already used at the top of the function. So yeah, fine like that 😅
kulmann
approved these changes
May 25, 2023
| context.commit('UPSERT_RESOURCES', fetchedResources) | ||
| context.commit('LOAD_INDICATORS', currentFolder.path) |
There was a problem hiding this comment.
True. And now that I looked at it in detail - the currentFolder is already used at the top of the function. So yeah, fine like that 😅
AlexAndBear
approved these changes
May 26, 2023
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Types of changes