Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle processing items #9561

Merged
merged 24 commits into from Aug 16, 2023
Merged

Handle processing items #9561

merged 24 commits into from Aug 16, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Aug 9, 2023 •
edited

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Aug 9, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

AlexAndBear
AlexAndBear commented Aug 9, 2023
View reviewed changes
packages/web-client/src/helpers/resource/functions.ts Outdated
@@ -99,7 +98,7 @@ export function buildResource(resource): Resource {
webDavPath: resource.name,
type: isFolder ? 'folder' : resource.type,
isFolder,
processing: resource.processing || false,
processing: resource.type === 'file',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mock stuff

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Aug 9, 2023 •
edited

ctrl + shift -> still selecting

@tbsbdr
Copy link
Contributor

tbsbdr commented Aug 9, 2023

nice one!
I like the grey background, but this leads to too low contrast (a11y vialoation) I propose to increase opacity from .6 to .7 so that we can keep the muted background and provide enough contrast to comply with WCAG 2.1 AA.

@AlexAndBear
Copy link
Contributor Author

nice one! I like the grey background, but this leads to too low contrast (a11y vialoation) I propose to increase opacity from .6 to .7 so that we can keep the muted background and provide enough contrast to comply with WCAG 2.1 AA.

done

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Aug 9, 2023 •
edited

Things to do/discuss

  • Add mechanism to favorites / shared with views? @tbsbdr
  • Show processing state in search preview / hide? @tbsbdr

JammingBen
JammingBen reviewed Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, IMO you fulfilled the ACs here. Small annotations from my side:

  • When a file list only consists of disabled items, the top-left checkbox is being checked image
  • I find the checkboxes for disabled resources in the tiles view irritating. In the table that's not an issue, probably because a row is easily identified as disabled. That's not the case with tiles. Especially in dark mode there is nearly no difference. We could solve that by increasing the contrast, but it may be hard because it always depends on the preview image. Maybe hiding the checkbox and the 3-dots-menu is an option?
    image
  • Right clicking disabled resources in the table shows the "whitespace context menu", while right clicking disabled resources in the tiles view shows the browser context menu. No hard feelings, but I'd vote for going the tiles-way by not showing the "whitespace context menu" in such case.

Add mechanism to favorites / shared with views?
Show processing state in search preview / hide?

In general yes, although both APIs don't return the processing state for now. But I guess it will in the future, so it would be nice to have that implemented already.

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Aug 10, 2023 •
edited

All done besides point 2. Needs decision by @tbsbdr

AlexAndBear
AlexAndBear commented Aug 11, 2023
View reviewed changes
packages/web-app-files/src/helpers/resources.ts Outdated
@@ -168,7 +168,8 @@ export function buildSharedResource(
indicators: [],
tags: [],
path: undefined,
webDavPath: undefined
webDavPath: undefined,
processing: !isFolder
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mock

AlexAndBear
AlexAndBear commented Aug 11, 2023
View reviewed changes
packages/web-client/src/helpers/resource/functions.ts Outdated
@@ -99,7 +98,7 @@ export function buildResource(resource): Resource {
webDavPath: resource.name,
type: isFolder ? 'folder' : resource.type,
isFolder,
processing: resource.processing || false,
processing: resource.type === 'file',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mock

@AlexAndBear
Copy link
Contributor Author

Keyboard actions broken on search -,.-

lookacat
lookacat suggested changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small things, other than this looks good 👍🏼

packages/design-system/src/components/OcTable/OcTable.vue Show resolved Hide resolved
packages/web-app-files/src/views/shares/SharedViaLink.vue Outdated Show resolved Hide resolved
lookacat
lookacat approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter fails, other than that LGTM 👍🏼

AlexAndBear
AlexAndBear commented Aug 15, 2023
View reviewed changes
packages/web-app-files/src/components/FilesList/ResourceTable.vue
Comment on lines +464 to +470
if (disabled) {
if (!Array.isArray(disabled)) {
disabled = [disabled]
}

return disabled
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coerce into array structure

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

32.2% 32.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@AlexAndBear AlexAndBear marked this pull request as ready for review August 16, 2023 11:39
@AlexAndBear AlexAndBear merged commit 9e70d5c into master Aug 16, 2023
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issues/9558 branch August 16, 2023 11:39
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@AlexAndBear
Handle processing items (#9561)
84ac435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lookacat lookacat lookacat approved these changes

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web] Display resource as disabled
4 participants
@AlexAndBear @tbsbdr @lookacat @JammingBen