Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Click on search icon executes search #9685

Closed
wants to merge 2 commits into from

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Sep 11, 2023

Description

see #9664

Related Issue

@lookacat lookacat marked this pull request as ready for review September 12, 2023 10:00
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen
Copy link
Collaborator

Actually the plan was to move the lens icon from left to right and replace the icon for "Open advanced search".

@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 19, 2023

@lookacat thanks for picking this up! sorry, expected behaviour in #9664 was described too scarce - added more descriptive text, please also have a look at the screenshot. looking forward to the PR!

@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 21, 2023

@lookacat I'd be happy if you continue here - if time permits

@lookacat
Copy link
Contributor Author

Closing this PR, moved to new PR because its the wrong implementation: #9858

@lookacat lookacat closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Settings-Icon from Search Bar
3 participants