Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tags for locked files #9873

Merged
merged 6 commits into from Oct 27, 2023
Merged

Disable tags for locked files #9873

merged 6 commits into from Oct 27, 2023

Conversation

grimmoc
Copy link
Contributor

@grimmoc grimmoc commented Oct 26, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@grimmoc
Copy link
Contributor Author

grimmoc commented Oct 26, 2023

@JammingBen I used the "disabled" property of the oc-select because it does not feature a readonly attribute and I can still read (= read only ;-)) the values that are selected. OK?

JammingBen
JammingBen reviewed Oct 27, 2023
View reviewed changes
docs/theming/_index.md Outdated Show resolved Hide resolved
@grimmoc
Revert "added docs"
6f9cfee 
This reverts commit 5844b8b.
@grimmoc grimmoc marked this pull request as ready for review October 27, 2023 12:40
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit fc884de into master Oct 27, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the disable-tags-for-locked-files branch October 27, 2023 18:25
@JammingBen JammingBen mentioned this pull request Oct 30, 2023
Merged
5 tasks
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@grimmoc @AlexAndBear
Disable tags for locked files (#9873)
705866f 
* disabled tags input for locked files in sidebar

* changelog entry

* removed explicit type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann left review comments

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editing tags of a locked resource should not be possible
4 participants
@grimmoc @kulmann @JammingBen @AlexAndBear