Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rendering of old/wrong set of resources in search list #9881

Merged
merged 2 commits into from Oct 30, 2023
Merged

fix: rendering of old/wrong set of resources in search list #9881

merged 2 commits into from Oct 30, 2023

Conversation

fschade
Copy link
Collaborator

@fschade fschade commented Oct 29, 2023

Description

When entering the search, it displayed the resources from the file list for a short moment,
this has now been fixed and the search always shows the loading spinner first.

After all results have been loaded from the server, the spinner disappears and the result is rendered.

Related Issue

Motivation and Context

the list should always be up to date and indicate the current state (loading) to the user

How Has This Been Tested?

  • unit tests
  • manual testing
  • e2e (ci)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@fschade fschade added Type:Bug Something isn't working Status:Needs-Review Needs review from a maintainer labels Oct 29, 2023
@fschade fschade self-assigned this Oct 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 97e22ad into master Oct 30, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-search-list-resource-set-rendering branch October 30, 2023 06:43
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@fschade @AlexAndBear
fix: rendering of old/wrong set of resources in search list (#9881)
c3dc74e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Assignees

@fschade fschade

Labels
Status:Needs-Review Needs review from a maintainer Type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opening the advanced search renders the current file list as search result
2 participants
@fschade @AlexAndBear