Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize "New" menu | Add default extension to menu item #9906

Merged
merged 11 commits into from Nov 3, 2023
Merged

Organize "New" menu | Add default extension to menu item #9906

merged 11 commits into from Nov 3, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Nov 2, 2023 •
edited

Description

See #9846

Related Issue

Screenshots (if appropriate):

Screenshot (89)
Screenshot (88)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Nov 2, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review November 2, 2023 15:03
AlexAndBear
AlexAndBear approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM, please add a changelog item

kulmann
kulmann reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two separator lines if there are no apps from the app provider... although the code doesn't read like that. o_O could you check that please?

@lookacat
Copy link
Contributor Author

lookacat commented Nov 3, 2023

yes will check it

@lookacat lookacat requested a review from kulmann November 3, 2023 11:52
@lookacat
Copy link
Contributor Author

lookacat commented Nov 3, 2023

@kulmann should be good to go now, fixed the line issue and added the url shortcut from rebase and unittests

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@lookacat lookacat merged commit 675275c into master Nov 3, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the 9846-organize-new-menu branch November 3, 2023 18:03
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@lookacat @AlexAndBear
Organize "New" menu | Add default extension to menu item (#9906)
c2b9e39 
* Organize New-Menu / add extensions

* WIP

* Fix styling add extension

* Only show extension if setting is enabled, Update snapshots

* Remove inline style

* Add changelog item

* Adjust min-width depending on file extensions shown

* Fix double seperator line

* Add unittests

* Fix typo

* Move url shortcut to bottom position in menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Organize New-Menu
3 participants
@lookacat @kulmann @AlexAndBear