Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trackerID to message card to allow cards to link to contacts. #1692

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

wir3z
Copy link
Contributor

@wir3z wir3z commented Apr 26, 2024

This is to address this issue: "Processed MessageCard message has no topic, preventing image cards from linking to Friends. #1684". (HTTP)

In 2.4.x, the incoming MessageLocation and MessageCard used the 'tid' (trackerID) as a unique to link the two from MessageBase. In 2.5, that field was removed from MessageBase.

For the "onFinalizeMessage" (HTTP), it would always return a null topic in the logs for all message types except MessageLocation.

@growse growse added this to the v2.5 milestone Jun 11, 2024
@growse growse added this pull request to the merge queue Jun 15, 2024
Merged via the queue into owntracks:master with commit bbb2b6c Jun 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants