added tests with default and named in the same moment

oxc-project · Jan 11, 2024 · 708a1fa · 708a1fa
1 parent 3f554d3
commit 708a1fa
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/crates/oxc_linter/fixtures/import/named-and-default-export.js b/crates/oxc_linter/fixtures/import/named-and-default-export.js
@@ -0,0 +1,3 @@
+export default {};
+
+export const foo = 10
diff --git a/crates/oxc_linter/src/rules/import/no_named_as_default_member.rs b/crates/oxc_linter/src/rules/import/no_named_as_default_member.rs
@@ -147,13 +147,16 @@ fn test() {
         r#"import baz, {a} from "./named-exports""#,
         r#"import baz from "./named-exports"; const jjj = bar.jjj"#,
         r#"import {a} from "./named-exports"; const baz = a.baz"#,
+        r#"import baz from "./default_export_default_property"; const d = baz.default;"#,
+        r#"import baz, {foo} from "./named-and-default-export"; const d = baz.default;"#,
     ];
 
     let fail = vec![
         r#"import baz from "./named-exports"; const a = baz.a;"#,
         r#"import baz from "./named-exports"; const a = baz["a"];"#,
         r#"import baz from "./named-exports"; baz.a();"#,
         r#"import baz, { bar } from "./named-exports"; const {a} = baz"#,
+        r#"import baz from "./named-and-default-export"; const {foo: _foo} = baz"#,
     ];
 
     Tester::new_without_config(NoNamedAsDefaultMember::NAME, pass, fail)

diff --git a/crates/oxc_linter/src/snapshots/no_named_as_default_member.snap b/crates/oxc_linter/src/snapshots/no_named_as_default_member.snap
@@ -3,32 +3,39 @@ source: crates/oxc_linter/src/tester.rs
 assertion_line: 154
 expression: no_named_as_default_member
 ---
-  ⚠ eslint-plugin-import(no-named-as-default-member): `"baz"` also has a named export `"a"`
+  ⚠ eslint-plugin-import(no-named-as-default-member): "baz" also has a named export "a"
    ╭─[index.js:1:1]
  1 │ import baz from "./named-exports"; const a = baz.a;
    ·                                              ─────
    ╰────
   help: Check if you meant to write `import {a} from "./named-exports"`
 
-  ⚠ eslint-plugin-import(no-named-as-default-member): `"baz"` also has a named export `"a"`
+  ⚠ eslint-plugin-import(no-named-as-default-member): "baz" also has a named export "a"
    ╭─[index.js:1:1]
  1 │ import baz from "./named-exports"; const a = baz["a"];
    ·                                              ────────
    ╰────
   help: Check if you meant to write `import {a} from "./named-exports"`
 
-  ⚠ eslint-plugin-import(no-named-as-default-member): `"baz"` also has a named export `"a"`
+  ⚠ eslint-plugin-import(no-named-as-default-member): "baz" also has a named export "a"
    ╭─[index.js:1:1]
  1 │ import baz from "./named-exports"; baz.a();
    ·                                    ─────
    ╰────
   help: Check if you meant to write `import {a} from "./named-exports"`
 
-  ⚠ eslint-plugin-import(no-named-as-default-member): `"baz"` also has a named export `"a"`
+  ⚠ eslint-plugin-import(no-named-as-default-member): "baz" also has a named export "a"
    ╭─[index.js:1:1]
  1 │ import baz, { bar } from "./named-exports"; const {a} = baz
    ·                                                   ─────────
    ╰────
   help: Check if you meant to write `import {a} from "./named-exports"`
 
+  ⚠ eslint-plugin-import(no-named-as-default-member): "baz" also has a named export "foo"
+   ╭─[index.js:1:1]
+ 1 │ import baz from "./named-and-default-export"; const {foo: _foo} = baz
+   ·                                                     ─────────────────
+   ╰────
+  help: Check if you meant to write `import {foo} from "./named-and-default-export"`
+