fix(parser): fix asi error diagnostic pointing at invalid text causin…

…g crash (#4163)
oxc-project · Jul 10, 2024 · a956d2e · a956d2e
1 parent 3ba7cfe
commit a956d2e
Show file tree

Hide file tree

Showing 8 changed files with 271 additions and 263 deletions.
diff --git a/crates/oxc_linter/src/snapshots/button_has_type.snap b/crates/oxc_linter/src/snapshots/button_has_type.snap
@@ -95,7 +95,7 @@ source: crates/oxc_linter/src/tester.rs
   × Expected a semicolon or an implicit semicolon after a statement, but found none
    ╭─[button_has_type.tsx:1:7]
  1 │ button type/>
-   ·       ─
+   ·       ▲
    ╰────
   help: Try insert a semicolon here
 

diff --git a/crates/oxc_linter/src/snapshots/consistent_indexed_object_style.snap b/crates/oxc_linter/src/snapshots/consistent_indexed_object_style.snap
@@ -222,6 +222,6 @@ source: crates/oxc_linter/src/tester.rs
   × Expected a semicolon or an implicit semicolon after a statement, but found none
    ╭─[consistent_indexed_object_style.tsx:1:10]
  1 │ funcction foo(): Record<string, any> {}
-   ·          ─
+   ·          ▲
    ╰────
   help: Try insert a semicolon here
diff --git a/crates/oxc_parser/src/cursor.rs b/crates/oxc_parser/src/cursor.rs
@@ -172,7 +172,7 @@ impl<'a> ParserImpl<'a> {
     /// # Errors
     pub(crate) fn asi(&mut self) -> Result<()> {
         if !self.can_insert_semicolon() {
-            let span = Span::new(self.prev_token_end, self.cur_token().start);
+            let span = Span::new(self.prev_token_end, self.prev_token_end);
             return Err(diagnostics::auto_semicolon_insertion(span));
         }
         if self.at(Kind::Semicolon) {

diff --git a/tasks/coverage/misc/fail/oxc-4111-1.js b/tasks/coverage/misc/fail/oxc-4111-1.js
@@ -0,0 +1 @@
+funtransientction as longciiConÞr>ol(cde) {