Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Stable Rust #626

Closed
Boshen opened this issue Jul 26, 2023 · 2 comments
Closed

Use Stable Rust #626

Boshen opened this issue Jul 26, 2023 · 2 comments
Labels
C-enhancement Category - New feature or request good first issue Experience Level - Good for newcomers

Comments

@Boshen
Copy link
Member

Boshen commented Jul 26, 2023 •
edited

Since we are now in serious business and publishing crates, let's move back to stable Rust.

https://twitter.com/en_JS/status/1676484656575946753

It would be really nice if it didn’t rely on nightly Rust. Nightly is cool for apps, but not for infra that others will build on.

To get started, change rust-toolchain.toml's channel to the latest <major.minor.patch>
(1.71.0) version, and run cargo check and fix all the code ;-)
@Boshen Boshen added C-enhancement Category - New feature or request good first issue Experience Level - Good for newcomers labels Jul 26, 2023
@strager strager mentioned this issue Jul 26, 2023
Merged
This was referenced Jul 26, 2023
Merged
Merged
@Boshen
Copy link
Member Author

Boshen commented Jul 26, 2023

Oh no we need to remove portable_simd 😢 Unless we can find a stable simd.

Boshen added a commit that referenced this issue Jul 27, 2023
@Boshen
refactor(parser): remove portable simd because it is not stable Rust
d594247 
related #626
@Boshen Boshen mentioned this issue Jul 27, 2023
Merged
Boshen added a commit that referenced this issue Jul 27, 2023
@Boshen
refactor(parser): remove portable simd because it is not stable Rust (#…
608ee91 
…645)

related #626
Boshen added a commit that referenced this issue Jul 27, 2023
@Boshen
chore: stable Rust
ee30eb2 
closes #626
Boshen added a commit that referenced this issue Jul 27, 2023
@Boshen
chore: stable Rust
eeb4f00 
closes #626
@Boshen Boshen closed this as completed in fa82f94 Jul 27, 2023
@Boshen
Copy link
Member Author

Boshen commented Jul 27, 2023

Released all crates as v0.1.0 🥳

https://crates.io/crates/oxc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category - New feature or request good first issue Experience Level - Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Boshen