Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unstable feature const_trait_impl & const_slice_index & slice_group_by #629

Merged
merged 3 commits into from
Jul 26, 2023
Merged

refactor: remove unstable feature const_trait_impl & const_slice_index & slice_group_by #629

merged 3 commits into from
Jul 26, 2023

Conversation

suica
Copy link
Contributor

@suica suica commented Jul 26, 2023 •
edited
Loading

for #626

  1. Removed const_trait_impl & const_slice_index.
  2. Removed slice_group_by.

@github-actions github-actions bot added the A-linter Area - Linter label Jul 26, 2023
@suica suica changed the title chore: remove unused feature tag chore: remove unused feature tags Jul 26, 2023
@github-actions github-actions bot added the A-minifier Area - Minifier label Jul 26, 2023
@suica suica changed the title chore: remove unused feature tags chore: remove unstable feature tags const_trait_impl & const_slice_index & slice_group_by Jul 26, 2023
@Boshen
Copy link
Member

Boshen commented Jul 26, 2023

Nice, I should use itertools more.

Boshen
Boshen requested changes Jul 26, 2023
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a quick cargo fmt?

@github-actions github-actions bot added the A-parser Area - Parser label Jul 26, 2023
@suica suica changed the title chore: remove unstable feature tags const_trait_impl & const_slice_index & slice_group_by chore: remove unstable feature tags const_trait_impl & const_slice_index & slice_group_by & slice_as_chunks Jul 26, 2023
@Boshen
Copy link
Member

Boshen commented Jul 26, 2023

Can I get separate PRs after this one? So we manage this more easily.

@suica
Copy link
Contributor Author

suica commented Jul 26, 2023

@Boshen Ok, I'll leave the slice_as_chunks, and make another PR.

@suica suica changed the title chore: remove unstable feature tags const_trait_impl & const_slice_index & slice_group_by & slice_as_chunks chore: remove unstable feature const_trait_impl & const_slice_index & slice_group_by Jul 26, 2023
@suica suica changed the title chore: remove unstable feature const_trait_impl & const_slice_index & slice_group_by refactor: remove unstable feature const_trait_impl & const_slice_index & slice_group_by Jul 26, 2023
@github-actions github-actions bot removed the A-parser Area - Parser label Jul 26, 2023
@suica
Copy link
Contributor Author

suica commented Jul 26, 2023

@Boshen Ok, I'll leave the slice_as_chunks, and make another PR.

slice_as_chunks is removed in #632.

@Boshen Boshen merged commit fbb8aa3 into oxc-project:main Jul 26, 2023
@suica suica deleted the rust-stable branch July 26, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter A-minifier Area - Minifier
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suica @Boshen