Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIR is a blocker for working on the parser. #814

Closed
Boshen opened this issue Aug 30, 2023 · 0 comments · Fixed by #917
Closed

HIR is a blocker for working on the parser. #814

Boshen opened this issue Aug 30, 2023 · 0 comments · Fixed by #917
Assignees
@Boshen

Comments

@Boshen
Copy link
Member

Boshen commented Aug 30, 2023

so just coverage requires that the ast + hir work was done before parser_typescript.snap is updated/written to. But it makes sense why. I primarily used cargo watch -x "run -p oxc_parser --example parser" for working on the code.

Originally posted by @camc314 in #811 (comment)
@Boshen Boshen self-assigned this Aug 30, 2023
@Boshen Boshen mentioned this issue Sep 15, 2023
Merged
Boshen added a commit that referenced this issue Sep 15, 2023
@Boshen
Remove HIR (#917)
ceeee59 
closes #273
closes #814

HIR is removed from this PR, with the minifier being commented out.

HIR is a wonderful idea for compiling to lower languages, but after
sitting on it for a few months I found that it only adds confusion and
uncertainties to both myself and future contributors.

It also adds too much burden to maintainers if we plan to support more
downstream tools.

1 AST is the only way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove HIR oxc-project/oxc
1 participant
@Boshen