-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): TypeScript 5.2 #811
Conversation
Oh wow this is awesome! I'll review this tomorrow since it is getting late here. One quick question - how do you like the whole experience? Any suggestions for improvements would be greatly appreciated. |
Unfortunately the CLA needs to be signed. |
Thanks! Not really, it was pretty smooth. It was nice that I didn't have to go diving through the repo and you included all the detail in the issue - link to the TS release notes, instructions for One of the bits that slowed me down a bit was that: so But overall it looks great! You've done a fantastic job with the project so far. And the readme contains everything I could want to know about the project.
Thanks. Working with me Employer to get it signed 🙂. |
This is a blocker, I should move it to another stage or rethink about HIR. Thank you for this, things like this will make future contributions easier. |
HIR is now removed. @camc314 Can I continue your work if you are not finding the time? |
CodSpeed Performance ReportMerging #811 will not alter performanceComparing Summary
|
I think this should be ready to go unless I've missed something - but feel free to take over let me know what you think |
Looking good, keep up with the good work 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nitpicks. This is really good overall.
Thank you so so much for working on this! ❤️ |
Closes #786