Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lexer) Fix spans for jsx children #1030

Merged
merged 1 commit into from
Oct 22, 2023
Merged

fix(lexer) Fix spans for jsx children #1030

merged 1 commit into from
Oct 22, 2023

Conversation

camc314
Copy link
Collaborator

@camc314 camc314 commented Oct 22, 2023

Closes #1026

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser labels Oct 22, 2023
@camc314 camc314 mentioned this pull request Oct 22, 2023
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 22, 2023

CodSpeed Performance Report

Merging #1030 will not alter performance

⚠️ No base runs were found

Falling back to comparing camc314:c/fix-jsx-span (7f2c936) with main (0167172)

Summary

✅ 22 untouched benchmarks

@Boshen Boshen merged commit 76ac9cd into oxc-project:main Oct 22, 2023
18 checks passed
@Boshen Boshen mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magic-akari magic-akari magic-akari approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter A-parser Area - Parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lexer incorrectly reports span starts for JSX children
3 participants
@camc314 @magic-akari @Boshen