Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter) eslint plugin unicorn: no array foreach #1613

Merged
merged 1 commit into from
Dec 3, 2023
Merged

feat(linter) eslint plugin unicorn: no array foreach #1613

merged 1 commit into from
Dec 3, 2023

Conversation

camc314
Copy link
Collaborator

@camc314 camc314 commented Dec 2, 2023

No description provided.

@camc314 camc314 mentioned this pull request Dec 2, 2023
Merged
@camc314 Graphite App
Copy link
Collaborator Author

camc314 commented Dec 2, 2023 •
edited

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@camc314 camc314 mentioned this pull request Dec 2, 2023
Closed
@github-actions github-actions bot added the A-linter Area - Linter label Dec 2, 2023
This was referenced Dec 2, 2023
Open
Merged
Base automatically changed from c/12-02-feat_linter_eslint_plugin_unicorn_no_array_reduce to main December 3, 2023 09:03
@camc314 camc314 force-pushed the c/12-02-feat_linter_eslint_plugin_unicorn_no_array_foreach branch from 3ecb680 to 9e8ab1f Compare December 3, 2023 16:13
@camc314 camc314 mentioned this pull request Dec 3, 2023
Merged
@camc314 camc314 enabled auto-merge (squash) December 3, 2023 16:14
@camc314 camc314 disabled auto-merge December 3, 2023 16:14
@camc314 camc314 merged commit e881ee2 into main Dec 3, 2023
17 of 31 checks passed
@camc314 camc314 deleted the c/12-02-feat_linter_eslint_plugin_unicorn_no_array_foreach branch December 3, 2023 16:17
@camc314 Graphite App
Copy link
Collaborator Author

camc314 commented Dec 3, 2023

Merge activity

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 3, 2023

CodSpeed Performance Report

Merging #1613 will improve performances by 5.25%

Comparing c/12-02-feat_linter_eslint_plugin_unicorn_no_array_foreach (9e8ab1f) with main (cfe207f)

Summary

⚡ 1 improvements
✅ 19 untouched benchmarks

Benchmarks breakdown

Benchmark main c/12-02-feat_linter_eslint_plugin_unicorn_no_array_foreach Change
⚡ semantic[vue.js] 79 ms 75 ms +5.25%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@camc314 @Boshen