feat(linter) oxc: only used in recursion

[camc314]

Inspired by https://rust-lang.github.io/rust-clippy/master/#/only_used_in_recursion

Examples from VSCode Repo

[camc314]

Current dependencies on/for this PR:

• main
  • PR feat(linter) oxc: misrefactored assign op #1832
    • PR feat(linter) oxc: only used in recursion #1833 👈
      • PR feat(linter) oxc: erasing op #1834

This stack of pull requests is managed by Graphite.

[camc314]

For the VSCode error, on createTOCIterator i looked into it - looks like it's removal was misseed as part of a refactoring 🙂

Was made recursive here: microsoft/vscode@ccb98c2

The use of the property was removed here:
https://github.com/microsoft/vscode/pull/74462/files#diff-290d58c5a12f00298e55d5a2993c95a7e313052c187e9009c67745c063072c61

but likley not noticed since it's used in the recursive call.

Another interesting point flagged by this rule was

https://github.com/microsoft/vscode/blob/6e8bc02be42611b78c2cc5dab3caed339ddd24fe/extensions/ipynb/src/test/serializers.test.ts#L12-L20

judging by the functions name and usage

usage:

https://github.com/microsoft/vscode/blob/6e8bc02be42611b78c2cc5dab3caed339ddd24fe/extensions/ipynb/src/test/serializers.test.ts#L142

you would expect that it only strips our properties passed in via the secon argument. however this is not the case!

[Boshen]

This is epic!

[IWANABETHATGUY]

Can you add a test case that function only used in recursion but is exported?
like:

module.exports = function test(a) {
  test(a)
}

export function test(a) {
  test(a)
}

[camc314]

done

[Boshen]

Merge activity

• Dec 27, 9:27 AM: @Boshen started a stack merge that includes this pull request via Graphite.
• Dec 27, 9:28 AM: Graphite rebased this pull request as part of a merge.
• Dec 27, 9:32 AM: @Boshen merged this pull request with Graphite.