feat(linter) oxc: erasing op

[camc314]

No description provided.

[camc314]

Current dependencies on/for this PR:

• main
  • PR feat(linter) oxc: misrefactored assign op #1832
    • PR feat(linter) oxc: only used in recursion #1833
      • PR feat(linter) oxc: erasing op #1834 👈

This stack of pull requests is managed by Graphite.

[Boshen]

I think we need to polish the help messages a bit.

This is most likely not the intended outcome.

Probably need some guidance on the action? How does clippy warn about this?

[camc314]

I think we need to polish the help messages a bit.

This is most likely not the intended outcome.

Probably need some guidance on the action? How does clippy warn about this?

From clippy:

warning: this operation will always return zero. This is likely not the intended outcome
  --> crates/oxc_linter/src/rules/oxc/erasing_op.rs:57:17
   |
57 |         let b = a * 0;
   |                 ^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op
   = note: `-W clippy::erasing-op` implied by `-W clippy::all`
   = help: to override `-W clippy::all` add `#[allow(clippy::erasing_op)]`

I updated the diagnostic to be:

  ⚠ oxc(erasing-op): Unexpected erasing operation. This expression will always evaluate to zero.
   ╭─[erasing_op.tsx:1:1]
 1 │ x * 0;
   · ─────
   ╰────
  help: This is most likely not the intended outcome. Consider removing the operation, or directly assigning zero to the variable