Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): disallow path pointing to parent directories #2125

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 22, 2024

Linting parent directories introduces undefined behavior because
the intention is not clear. This is a future proof precaution.

closes #1887

Linting parent directories introduces undefined behavior because
the intention is not clear. This is a future proof precaution.

closes #1887
Copy link
Member Author

Boshen commented Jan 22, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added the A-cli Area - CLI label Jan 22, 2024
@Boshen Boshen merged commit a978639 into main Jan 22, 2024
19 checks passed
Copy link
Member Author

Boshen commented Jan 22, 2024

Merge activity

@Boshen Boshen deleted the 01-22-feat_cli_disallow_path_pointing_to_parent_directories branch January 22, 2024 09:52
Copy link

codspeed-hq bot commented Jan 22, 2024

CodSpeed Performance Report

Merging #2125 will not alter performance

Comparing 01-22-feat_cli_disallow_path_pointing_to_parent_directories (a2654f3) with main (d00c44c)

Summary

✅ 17 untouched benchmarks

IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
…2125)

Linting parent directories introduces undefined behavior because
the intention is not clear. This is a future proof precaution.

closes oxc-project#1887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oxlint reports incorrect errors when it receives a relative path starting with ..
1 participant