Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ast): remove serde skip for symbol_id and reference_id #2220

Merged
merged 1 commit into from
Jan 30, 2024
Merged

feat(ast): remove serde skip for symbol_id and reference_id #2220

merged 1 commit into from
Jan 30, 2024

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 30, 2024 •
edited

We want to see symbol_id and reference_id in ast

@Dunqing
Copy link
Member Author

Dunqing commented Jan 30, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added the A-ast Area - AST label Jan 30, 2024
@Dunqing Dunqing force-pushed the 01-30-feat_ast_remove_serde_skip_for_symbol_id_and_reference_id branch 2 times, most recently from 4b389b7 to 976843b Compare January 30, 2024 07:57
@Dunqing
Copy link
Member Author

Dunqing commented Jan 30, 2024

cc @hyf0

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 30, 2024 •
edited

CodSpeed Performance Report

Merging #2220 will not alter performance

Comparing 01-30-feat_ast_remove_serde_skip_for_symbol_id_and_reference_id (097db3e) with main (81e33a3)

Summary

✅ 17 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Jan 30, 2024

It failed to compile https://github.com/oxc-project/oxc/actions/runs/7707957018/job/21006084925?pr=2220

@Dunqing Dunqing force-pushed the 01-30-feat_ast_remove_serde_skip_for_symbol_id_and_reference_id branch 2 times, most recently from 2660606 to 66221aa Compare January 30, 2024 10:33
@github-actions github-actions bot added the A-semantic Area - Semantic label Jan 30, 2024
@Boshen
Copy link
Member

Boshen commented Jan 30, 2024

"Check Unused Dependencies" failed :-(

@Dunqing Dunqing force-pushed the 01-30-feat_ast_remove_serde_skip_for_symbol_id_and_reference_id branch from 66221aa to 097db3e Compare January 30, 2024 11:30
@Boshen Boshen merged commit f673e41 into main Jan 30, 2024
18 checks passed
@Boshen Boshen deleted the 01-30-feat_ast_remove_serde_skip_for_symbol_id_and_reference_id branch January 30, 2024 13:03
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@Dunqing @IWANABETHATGUY
feat(ast): remove serde skip for symbol_id and reference_id (oxc-proj…
870e274 
…ect#2220)

We want to see symbol_id and reference_id in ast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-ast Area - AST A-semantic Area - Semantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dunqing @Boshen