Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better report source line and col for multiline annotations #2242

Conversation

maurice
Copy link
Contributor

@maurice maurice commented Jan 31, 2024

Improves diagnostic report source line- and column-number for multiline annotations

Requires #2241

Copy link

codspeed-hq bot commented Jan 31, 2024

CodSpeed Performance Report

Merging #2242 will not alter performance

Comparing maurice:fix/better-report-source-line-and-col-for-multiline-annotations (2eca26c) with main (9bbdec1)

Summary

✅ 17 untouched benchmarks

@Boshen Boshen force-pushed the fix/better-report-source-line-and-col-for-multiline-annotations branch from 643bf8b to 2eca26c Compare February 1, 2024 03:33
@Boshen Boshen merged commit 6b2150f into oxc-project:main Feb 1, 2024
19 checks passed
@maurice maurice deleted the fix/better-report-source-line-and-col-for-multiline-annotations branch February 1, 2024 07:47
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
…ect#2242)

Improves diagnostic report source line- and column-number for
**multiline annotations**

Requires oxc-project#2241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants