fix(linter/jsx_a11y): Ensure plugin settings are used #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2359 will not alter performanceComparing Summary
|
|
This is awesome! Thank you so much! |
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
Currently, some of the rules did not use `settings`, so make sure they do. - [x] Align implementation of `getElementType()` - (This is the only util that depends on `settings`) Original rules which use `getElementType()` are: - [x] 🙅🏻♂️ accessible-emoji - [x] ✅ alt-text - [x] 🙅🏻♂️ anchor-ambiguous-text - [x] ✅ anchor-has-content - [x] anchor-is-valid - TODO: `from_configuration()` not implemented => oxc-project#2361 - [x] 🙆🏻♀️ aria-activedescendant-has-tabindex - [x] 🙆🏻♀️ aria-role - [x] 🙆🏻♀️ aria-unsupported-elements - [x] autocomplete-valid - TODO: `from_configuration()` not implemented and needed for this => oxc-project#2362 - [x] 🙆🏻♀️ click-events-have-key-events - [x] 🙅🏻♂️ control-has-associated-label - [x] heading-has-content - TODO: 1 test should be failed but passes 🤔 => oxc-project#2360 - [x] 🙆🏻♀️ html-has-lang - [x] ✅ iframe-has-title - [x] 🙆🏻♀️ img-redundant-alt - [x] 🙅🏻♂️ interactive-supports-focus - [x] 🙅🏻♂️ label-has-associated-control - [x] 🙅🏻♂️ label-has-for - [x] 🙆🏻♀️ lang - [x] 🙆🏻♀️ media-has-caption - [x] ✅ no-aria-hidden-on-focusable - [x] 🙆🏻♀️ no-autofocus - [x] 🙆🏻♀️ no-distracting-elements - [x] 🙅🏻♂️ no-interactive-element-to-noninteractive-role - [x] 🙅🏻♂️ no-noninteractive-element-interactions - [x] 🙅🏻♂️ no-noninteractive-element-to-interactive-role - [x] 🙅🏻♂️ no-noninteractive-tabindex - [x] 🙅🏻♂️ no-onchange - [x] 🙆🏻♀️ no-redundant-roles - [x] 🙅🏻♂️ no-static-element-interactions - [x] ✅ prefer-tag-over-role - [x] 🙆🏻♀️ role-has-required-aria-props - [x] 🙆🏻♀️ role-supports-aria-props - [x] 🙆🏻♀️ scope 🙅🏻♂️ = Not implemented yet by oxlint / ✅ = Fixed by this PR / 🙆🏻♀️ = Already used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some of the rules did not use
settings, so make sure they do.getElementType()settings)Original rules which use
getElementType()are:from_configuration()not implemented => linter: Implementfrom_configuration()forjsx_a11y/anchor-is-valid#2361from_configuration()not implemented and needed for this => linter: Implementfrom_configuration()forjsx_a11y/autocomplete-valid#2362heading-has-contenttest pass #2360🙅🏻♂️ = Not implemented yet by oxlint / ✅ = Fixed by this PR / 🙆🏻♀️ = Already used