Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): eslint-plugin-jest: prefer-expect-resolves #2703

Merged

Conversation

eryue0220
Copy link
Contributor

Rule Detail: link

@eryue0220 eryue0220 marked this pull request as ready for review March 13, 2024 06:01
@github-actions github-actions bot added the A-linter Area - Linter label Mar 13, 2024
Copy link

codspeed-hq bot commented Mar 13, 2024

CodSpeed Performance Report

Merging #2703 will improve performances by 12.15%

Comparing eryue0220:feat/jest-prefer-expect-resolves (e4aa672) with main (798a1fd)

Summary

⚡ 2 improvements
✅ 27 untouched benchmarks

🆕 5 new benchmarks

Benchmarks breakdown

Benchmark main eryue0220:feat/jest-prefer-expect-resolves Change
🆕 parser(napi)[RadixUIAdoptionSection.jsx] N/A 6.3 ms N/A
🆕 parser(napi)[antd.js] N/A 15.4 s N/A
🆕 parser(napi)[cal.com.tsx] N/A 4 s N/A
🆕 parser(napi)[checker.ts] N/A 6.7 s N/A
🆕 parser(napi)[pdf.mjs] N/A 2.5 s N/A
codegen_sourcemap[react.development.js] 15.9 ms 15.3 ms +3.94%
codegen_sourcemap[typescript.js] 1.6 s 1.5 s +12.15%

@Boshen Boshen requested a review from mysteryven March 13, 2024 11:13
Copy link
Member

@mysteryven mysteryven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nitpick.

@mysteryven mysteryven merged commit 9edda49 into oxc-project:main Mar 16, 2024
20 checks passed
@eryue0220 eryue0220 deleted the feat/jest-prefer-expect-resolves branch April 2, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants