Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement no-shadow-restricted-names #277

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

CarrotzRule123
Copy link
Contributor

Implement the Eslint rule no-shadow-restricted-names mentioned in #123.

@CarrotzRule123
Copy link
Contributor Author

CarrotzRule123 commented Apr 14, 2023

Weird, it passed the first time.
There seems to be a network error?
thread 'test' panicked at 'called `Result::unwrap()` on an `Err` value: "Status(502, Response[status: 502, status_text: Bad Gateway, url: https://unpkg.com/echarts@5.1.1/dist/echarts.js])"', tasks/common/src/test_file.rs:24:45

@Boshen
Copy link
Member

Boshen commented Apr 14, 2023

Weird, it passed the first time. There seems to be a network error? thread 'test' panicked at 'called `Result::unwrap()` on an `Err` value: "Status(502, Response[status: 502, status_text: Bad Gateway, url: https://unpkg.com/echarts@5.1.1/dist/echarts.js])"', tasks/common/src/test_file.rs:24:45

unpkg seems unreliable, I'll change it to another CDN

@Boshen Boshen added first-pr A-linter Area - Linter labels Apr 14, 2023
@Boshen Boshen merged commit 1612313 into oxc-project:main Apr 14, 2023
@Boshen
Copy link
Member

Boshen commented Apr 14, 2023

Awesome! Thank you for contributing to oxc! I hope you enjoyed some Rust 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants