Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove oxc_transformer for a reimplementation #2865

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Mar 30, 2024

closes #2860

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Mar 30, 2024
Copy link
Member Author

Boshen commented Mar 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Mar 30, 2024

CodSpeed Performance Report

Merging #2865 will improve performances by 21.42%

Comparing nuke-transformer (b755354) with main (31ed532)

Summary

⚡ 5 improvements
✅ 31 untouched benchmarks

Benchmarks breakdown

Benchmark main nuke-transformer Change
transformer[RadixUIAdoptionSection.jsx] 719.2 µs 692.7 µs +3.82%
transformer[antd.js] 1.5 s 1.4 s +4.5%
transformer[cal.com.tsx] 417.7 ms 344 ms +21.42%
transformer[checker.ts] 930.3 ms 892.8 ms +4.19%
transformer[pdf.mjs] 264 ms 252.2 ms +4.69%

@Boshen Boshen merged commit c1a2958 into main Mar 30, 2024
34 checks passed
@Boshen Boshen deleted the nuke-transformer branch March 30, 2024 09:19
@Dunqing
Copy link
Member

Dunqing commented Mar 30, 2024

Seems we can keep the plugin’s struct and remove the impl

@Boshen
Copy link
Member Author

Boshen commented Mar 30, 2024

Seems we can keep the plugin’s struct and remove the impl

Starting from scratch will lead us to better code 😁

eryue0220 added a commit to eryue0220/oxc that referenced this pull request Apr 2, 2024
…eryue0220/oxc into feat/jest-prefer-promise-mock-shorthand

* 'feat/jest-prefer-promise-mock-shorthand' of github.com:eryue0220/oxc:
  chore: remove `oxc_transformer` for a reimplementation (oxc-project#2865)
Dunqing added a commit that referenced this pull request Aug 15, 2024
The implementation copy from the original implementation which removed in #2865.
Dunqing added a commit that referenced this pull request Aug 15, 2024
The implementation copy from the original implementation which removed in #2865.
Dunqing added a commit that referenced this pull request Aug 15, 2024
part of #4754

The implementation copy from the original implementation which removed in #2865.
Dunqing added a commit that referenced this pull request Aug 15, 2024
part of #4754

The implementation copy from the original implementation which removed in #2865.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transformer: nuke the current transformer implementation.
2 participants