feat(linter): no barrel file.

[rzvxa]

closes #3004

I've based it on this plugin instead of biome Since the original plugin is less likely to detect a false positive.

I didn't understand your statement here, Where you've mentioned:

In oxlint, we can do better when --import-plugin is enabled, by displaying the total number of dependencies pulled into a given file by walking

I would appreciate it if you expand upon it.

---

Edit:

I've added it under eslint-plugin-import even though it is not; I wasn't sure If I should create a whole new category for this single rule, It is a different story if we would like to adopt the other rules in here.

Also, check my diagnosis messages; It is my first contribution to the linters so I'm just not familiar enough with the conventions of messages, rules, etc.

[rzvxa]

• feat(linter): no barrel file. #3030 👈
• feat(syntax): module graph visitor. #3062 : 1 other dependent PR (#3064 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3030 will not alter performance

_{Comparing 04-19-feat_linter_no_barrel_file (113f6b8) with main (e6d11c6)}

Summary

✅ 30 untouched benchmarks

[Boshen]

I forced pushed some changes. The remaining check is on export type *.

[Boshen]

I didn't understand your statement #3004 (comment), Where you've mentioned:

In oxlint, we can do better when --import-plugin is enabled, by displaying the total number of dependencies pulled into a given file by walking

This is just a bonus. I want people see how many modules a simple export * imports.

This can be calculated by recursively walking loaded_modules and tally the total number of modules.

oxc/crates/oxc_syntax/src/module_record.rs

Line 41 in 6704546

pub loaded_modules: DashMap<CompactStr, Arc<ModuleRecord>, BuildHasherDefault<FxHasher>>,

You can find a similar walk in crates/oxc_linter/src/rules/import/no_cycle.rs.

[rzvxa]

I forced pushed some changes. The remaining check is on export type *.

Oh thanks, I didn't think of file extension since I had it copy pasted from a similar rule.

This can be calculated by recursively walking loaded_modules and tally the total number of modules.

Can this be an opt-in thing? Since with large import graphs (which is the primary characteristic for the barrel files), it is going to make a small but noticeable dent in performance.

In either case, I'll add it in, Let me know if you like the idea of making it an optional thing or not.

[Boshen]

Merge activity

• Apr 21, 10:09 PM EDT: @Boshen started a stack merge that includes this pull request via Graphite.
• Apr 21, 10:11 PM EDT: Graphite rebased this pull request as part of a merge.
• Apr 21, 10:18 PM EDT: @Boshen merged this pull request with Graphite.