fix(semantic): allow root_node to be empty for empty trees.

[rzvxa]

related to #3082, #3030 and #3069

[rzvxa]

• fix(semantic): allow root_node to be empty for empty trees. #3084 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3084 will degrade performances by 3.25%

_{Comparing 04-24-fix_semantic_allow_root_node_to_be_empty_for_empty_trees (00a37e9) with main (8de7399)}

Summary

❌ 1 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	04-24-fix_semantic_allow_root_node_to_be_empty_for_empty_trees	Change
❌	semantic[pdf.mjs]	138.2 ms	142.8 ms	-3.25%

[rzvxa]

@Boshen is this a false positive? I can't see how it would change the performance by this much unless it is because of memory layout. I'll mark it as draft until I find out.

CodSpeed Performance Report

Merging #3084 will degrade performances by 3.17%

Comparing 04-24-fix_semantic_allow_root_node_to_be_empty_for_empty_trees (38d4013) with main (8de7399)

Summary

❌ 1 regressions ✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 04-24-fix_semantic_allow_root_node_to_be_empty_for_empty_trees Change
❌ semantic[pdf.mjs] 138.2 ms 142.7 ms -3.17%

[Boshen]

@Boshen is this a false positive? I can't see how it would change the performance by this much unless it is because of memory layout. I'll mark it as draft until I find out.

CodSpeed Performance Report

Merging #3084 will degrade performances by 3.17%

Comparing 04-24-fix_semantic_allow_root_node_to_be_empty_for_empty_trees (38d4013) with main (8de7399)

Summary

❌ 1 regressions ✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 04-24-fix_semantic_allow_root_node_to_be_empty_for_empty_trees Change
❌ semantic[pdf.mjs] 138.2 ms 142.7 ms -3.17%

flaky test, just ignore.