fix(linter): avoid infinite loop in jest/expect-expect
#3332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mysteryven and the rest of your teammates on |
mysteryven
force-pushed
the
05-17-fix_3323
branch
from
0af29a1
to
1eaba29
Compare
Boshen
approved these changes
May 17, 2024
Merge activity
|
fix: #3324 I just replace `name` with a `set`, feel like this can catch more cases. And this rule needs to be [rewritten](#3323 (comment)).
CodSpeed Performance ReportMerging #3332 will not alter performanceComparing Summary
|
Brooooooklyn
pushed a commit
to toeverything/AFFiNE
that referenced
this pull request
Jun 11, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [oxlint](https://oxc.rs) ([source](https://togithub.com/oxc-project/oxc/tree/HEAD/npm/oxlint)) | [`0.3.5` -> `0.4.3`](https://renovatebot.com/diffs/npm/oxlint/0.3.5/0.4.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oxc-project/oxc (oxlint)</summary> ### [`v0.4.3`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.4.3): oxlint v0.4.3 [Compare Source](https://togithub.com/oxc-project/oxc/compare/031bbe6dc4b0707b324bee7c9f49543a4c8bf212...4b9a36512ec5186babdf726e604336bfc6838f6c) #### \[0.4.3] - 2024-06-07 ##### Features - [`1fb9d23`](https://togithub.com/oxc-project/oxc/commit/1fb9d23) linter: Add fixer for no-useless-fallback-in-spread rule ([#​3544](https://togithub.com/oxc-project/oxc/issues/3544)) (Don Isaac) - [`6506d08`](https://togithub.com/oxc-project/oxc/commit/6506d08) linter: Add fixer for no-single-promise-in-promise-methods ([#​3531](https://togithub.com/oxc-project/oxc/issues/3531)) (Don Isaac) - [`daf559f`](https://togithub.com/oxc-project/oxc/commit/daf559f) linter: Eslint-plugin-jest/no-large-snapshot ([#​3436](https://togithub.com/oxc-project/oxc/issues/3436)) (cinchen) - [`4c17bc6`](https://togithub.com/oxc-project/oxc/commit/4c17bc6) linter: Eslint/no-constructor-return ([#​3321](https://togithub.com/oxc-project/oxc/issues/3321)) (谭光志) - [`4a075cc`](https://togithub.com/oxc-project/oxc/commit/4a075cc) linter/jsdoc: Implement require-param rule ([#​3554](https://togithub.com/oxc-project/oxc/issues/3554)) (Yuji Sugiura) - [`747500a`](https://togithub.com/oxc-project/oxc/commit/747500a) linter/jsdoc: Implement require-returns-type rule ([#​3458](https://togithub.com/oxc-project/oxc/issues/3458)) (Yuji Sugiura) - [`6b39654`](https://togithub.com/oxc-project/oxc/commit/6b39654) linter/tree-shaking: Support options ([#​3504](https://togithub.com/oxc-project/oxc/issues/3504)) (Wang Wenzhe) ##### Bug Fixes - [`b188778`](https://togithub.com/oxc-project/oxc/commit/b188778) linter/eslint: Fix `require-await` false positives in `ForOfStatement`. ([#​3457](https://togithub.com/oxc-project/oxc/issues/3457)) (rzvxa) - [`350cd91`](https://togithub.com/oxc-project/oxc/commit/350cd91) parser: Should parser error when function declaration has no name ([#​3461](https://togithub.com/oxc-project/oxc/issues/3461)) (Dunqing) ### [`v0.4.2`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.4.2): oxlint v0.4.2 [Compare Source](https://togithub.com/oxc-project/oxc/compare/d971c9cd0b7da94896179ebd5a8b95b62d05a1c1...031bbe6dc4b0707b324bee7c9f49543a4c8bf212) #### What's Changed ##### Linter - `require-await` by [@​todor-a](https://togithub.com/todor-a) in [oxc-project/oxc#3406 - `eslint-plugin-unicorn/no-magic-array` flat depth by [@​camc314](https://togithub.com/camc314) in [oxc-project/oxc#3411 - `@typescript-eslint/consistent-indexed-object-style` by [@​todor-a](https://togithub.com/todor-a) in [oxc-project/oxc#3126 - `oxc/no-async-await` rule by [@​mysteryven](https://togithub.com/mysteryven) in [oxc-project/oxc#3438 - `oxc/no-const-enum` rule by [@​mysteryven](https://togithub.com/mysteryven) in [oxc-project/oxc#3435 - `oxc/no-rest-spread-properties` rule by [@​mysteryven](https://togithub.com/mysteryven) in [oxc-project/oxc#3432 - `eslint-plugin-jest/prefer-hooks-on-top` by [@​eryue0220](https://togithub.com/eryue0220) in [oxc-project/oxc#3437 - `eslint-plugin-jest/require-top-level-describe` by [@​eryue0220](https://togithub.com/eryue0220) in [oxc-project/oxc#3439 - `no-div-regex` by [@​jelly](https://togithub.com/jelly) in [oxc-project/oxc#3442 - `no-useless-concat` by [@​jelly](https://togithub.com/jelly) in [oxc-project/oxc#3363 - prefer-string-starts-ends-with: accept more valid regex by [@​magic-akari](https://togithub.com/magic-akari) in [oxc-project/oxc#3408 ##### Parser - fix(parser): parse const extends in arrow functions correctly by [@​Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#3450 #### New Contributors - [@​Bassadin](https://togithub.com/Bassadin) made their first contribution in [oxc-project/oxc#3433 **Full Changelog**: oxc-project/oxc@oxlint_v0.4.1...oxlint_v0.4.2 ### [`v0.4.1`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.4.1): oxlint v0.4.1 [Compare Source](https://togithub.com/oxc-project/oxc/compare/e5337f00b1c7b49cb09d28b860e112d4ebad3233...d971c9cd0b7da94896179ebd5a8b95b62d05a1c1) #### What's Changed - fix(parser): fix lexer error while parsing parenthesized arrow expressions by [@​Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3400 The previous version refactored some parsing code around arrow expressions, which failed to parse the following snippet correctly ```javascript (/\./.exec()) ``` **Full Changelog**: oxc-project/oxc@oxlint_v0.4.0...oxlint_v0.4.1 ### [`v0.4.0`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.4.0): oxlint v0.4.0 [Compare Source](https://togithub.com/oxc-project/oxc/compare/754d9f4c98aab052cf6b2756f7af12557042708d...e5337f00b1c7b49cb09d28b860e112d4ebad3233) #### Potential Breaking Changes ##### enforce rule severity from the cli and configuration file by [@​Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3337 The `--deny` or `-D` flag in the CLI, and the `"error"` severity setting in the configuration file will now set linter diagnostics to be an "error" and exit the program with exit code 1. Previously, these flags had no effect, and all linter diagnostics were reported as warnings. This means in CI, `oxlint --deny-warnings` is no longer needed for exit code 1 if `oxlint -D correctness` is set. To restore the previous "report as warning" behaviour, the `--warn` or `-W` flag is added to the CLI, and the `"warn"` severity in the configuration file will take into effect. ##### merge deepscan rules into oxc rules by [@​Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3327 `deepscan` rules are now "oxc" rules, because there is no "deepscan" plugin in the eslint ecosystem and this caused some confusion. #### Ecosystem CI We added the [`Oxlint Ecosystem CI`](https://togithub.com/oxc-project/oxlint-ecosystem-ci/actions/workflows/ecosystem-ci.yml) to maximize ecosystem compatibility, reduce churn, and minimize break-after-release #### New Features - `--disable-oxc-plugin` by [@​Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3328 - `--disable`-react/unicorn/typescript-`plugin` by [@​Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3305 The default rule set enables some plugins by default, the following CLI arguments are added for disabling them: - `--disable-react-plugin` - `--disable-unicorn-plugin` - `--disable-oxc-plugin` - `--disable-typescript-plugin` #### New Rules Two notable new rules that are under experiment but worth a try: ##### No Barrel File `oxlint --import-plugin -D no-barrel-file` Loading a lot of modules is slow for runtimes and bundlers. <img width="600" alt="image" src="https://github.com/oxc-project/oxc/assets/1430279/964d8615-a5c2-4934-a1e4-a6f8b023e199"> To change the threshhold: `oxlint -c oxlintrc.json --import-plugin -D no-barrel-file` ```json { "rules": { "oxc/no-barrel-file": ["error", { "threshold": 10 }] } } ``` See [Speeding up the JavaScript ecosystem - The barrel file debacle](https://marvinh.dev/blog/speeding-up-javascript-ecosystem-part-7) for background reading. ##### Rule of Hooks `oxlint -D rules-of-hooks` Enforce the React Rules of Hooks. - `eslint-plugin-jest/no-duplicate-hooks` by [@​eryue0220](https://togithub.com/eryue0220) in [oxc-project/oxc#3358 - `default-case` rule by [@​jelly](https://togithub.com/jelly) in [oxc-project/oxc#3379 - `no-new` by [@​jelly](https://togithub.com/jelly) in [oxc-project/oxc#3368 - `prefer-exponentiation-operator` by [@​jelly](https://togithub.com/jelly) in [oxc-project/oxc#3365 - `symbol-description` by [@​jelly](https://togithub.com/jelly) in [oxc-project/oxc#3364 - `jsdoc/require-returns-description` by [@​leaysgur](https://togithub.com/leaysgur) in [oxc-project/oxc#3397 #### Bug Fixes - fix(linter): avoid infinite loop in `jest/expect-expect` by [@​mysteryven](https://togithub.com/mysteryven) in [oxc-project/oxc#3332 - fix(linter): avoid infinite loop when traverse ancestors in `jest/no_conditional_expect` by [@​mysteryven](https://togithub.com/mysteryven) in [oxc-project/oxc#3330 - fix(linter): fix panic in jest/expect-expect by [@​Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3324 - fix(linter/jsx-no-undef): check for globals when an identifier is undefined by [@​Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3331 - fix(linter/next): false positives for non-custom font link by [@​Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#3383 #### Performance Improvements - perf(lexer): use bitshifting when parsing known integers by [@​DonIsaac](https://togithub.com/DonIsaac) in [oxc-project/oxc#3296 - perf(linter): use `usize` for `RuleEnum` hash by [@​Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3336 - perf(parser): more efficient number parsing by [@​overlookmotel](https://togithub.com/overlookmotel) in [oxc-project/oxc#3342 - perf(parser): use `FxHashSet` for `not_parenthesized_arrow` by [@​Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3344 - perf(parser): improve `parse_simple_arrow_function_expression` by [@​Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3349 - perf(parser): improve expression parsing by [@​Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3352 - perf(parser): improve is_parenthesized_arrow_function_expression by [@​Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#3343 #### What's coming next - Published JSON schema for configuration file - More features to the configuration file - Automatically synced and never outdated documentation website pages - [Command-line Interface](https://oxc-project.github.io/docs/guide/usage/linter/cli.html) - [Configuration File](https://oxc-project.github.io/docs/guide/usage/linter/config.html) - [Rules Page](https://oxc-project.github.io/docs/guide/usage/linter/rules.html) **Full Changelog**: oxc-project/oxc@oxlint_v0.3.5...oxlint_v0.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInRhcmdldEJyYW5jaCI6ImNhbmFyeSIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3324
I just replace
namewith aset, feel like this can catch more cases. And this rule needs to be rewritten.