fix(linter): memorize visited block id in neighbors_filtered_by_edge_weight

[mysteryven]

closes: #3396

we visit the same node too many times, I picked some result from run require-render-return rule on timeserieseexploere.js

    NodeIndex(64): 368640,
    NodeIndex(67): 737280,
    NodeIndex(70): 2949120,
    NodeIndex(73): 5971968,
    NodeIndex(76): 11943936,
    NodeIndex(43): 184320,
    NodeIndex(71): 2985984,
    NodeIndex(65): 368640,
    NodeIndex(68): 1474560,
    NodeIndex(74): 5971968,
    NodeIndex(77): 23887872,
    NodeIndex(44): 184320,
    NodeIndex(41): 73728,
    NodeIndex(35): 36864,
    NodeIndex(66): 737280,
    NodeIndex(69): 1474560,
    NodeIndex(72): 2985984,
    NodeIndex(75): 11943936,

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[mysteryven]

• feat(linter/eslint): add no_unreachable rule. #3238 : 2 dependent PRs (#3631 , #3650 )
• feat(semantic/cfg): propagate unreachable edges through subgraphs. #3648
• feat(semantic/cfg): add Condition instruction. #3567
• feat(semantic/cfg): add iteration instructions. #3566
• improvement(semantic/cfg): better control flow for switch statements. #3547
• improvement(semantic/cfg): rework error path. #3519
• improvement(semantic/cfg): better throw control flow. #3473
• improvement(linter/react): use CFG for detecting cyclic subgraphs in rules-of-hooks. #3454
• improvement(semantic/cfg): better CFG API #3472
• improvement(semantic/cfg): better break and continue flow. #3462
• improvement(semantic/cfg): better control flow for ForStatements. #3453
• improvement(semantic/cfg): better control flow for DoWhileStatements. #3452
• improvement(semantic/cfg): better control flow for WhileStatements. #3451
• improvement(semantic/cfg): rework basic blocks. #3381
• fix(linter): memorize visited block id in neighbors_filtered_by_edge_weight #3407 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mysteryven and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3407 will not alter performance

_{Comparing 05-24-fix_linter_memorize_visited_block_id_in_neighbors_filtered_by_edge_weight_ (5e06298) with main (3855579)}

Summary

✅ 22 untouched benchmarks

[rzvxa]

@mysteryven I didn't mean to force push here, I just stacked my PR on top of it, Didn't know it would result in this sorry about it.

[rzvxa]

Well now that the cat is out of the bag, I may as well go ahead and restack it properly doing the appropriate CFG changes. Sorry for the inconvenience!

[graphite-app]

Merge activity

• May 26, 4:01 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• May 26, 4:11 AM EDT: Boshen added this pull request to the Graphite merge queue.
• May 26, 4:15 AM EDT: Boshen merged this pull request with the Graphite merge queue.

[Boshen]

I screwed up the rebase 🤔