Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(semantic/cfg): better throw control flow. #3473

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented May 30, 2024

Copy link

graphite-app bot commented May 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label May 30, 2024
@rzvxa rzvxa changed the title improvement(linter/react): use new CFG for detection conditional nodes. improvement(linter/react): use new CFG for detecting conditional nodes. May 30, 2024
Copy link

codspeed-hq bot commented May 30, 2024

CodSpeed Performance Report

Merging #3473 will not alter performance

Comparing 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes (60f89d1) with main (0007ee4)

Summary

✅ 22 untouched benchmarks

@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 4b744cb to 393541f Compare May 30, 2024 17:45
@rzvxa rzvxa force-pushed the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch from fbf759a to 9ee8009 Compare May 30, 2024 17:45
@rzvxa rzvxa changed the title improvement(linter/react): use new CFG for detecting conditional nodes. improvement(linter/react): use new CFG for detecting conditional nodes in rules_of_hooks. May 30, 2024
@rzvxa rzvxa changed the title improvement(linter/react): use new CFG for detecting conditional nodes in rules_of_hooks. improvement(linter/react): use new CFG for detecting conditional nodes in rules-of-hooks. May 30, 2024
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 393541f to 575a3d3 Compare May 30, 2024 18:11
@rzvxa rzvxa force-pushed the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch from 9ee8009 to f92027a Compare May 30, 2024 18:11
@rzvxa rzvxa changed the title improvement(linter/react): use new CFG for detecting conditional nodes in rules-of-hooks. improvement(semantic/cfg): better throw control flow. May 30, 2024
@github-actions github-actions bot added the A-semantic Area - Semantic label May 30, 2024
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 575a3d3 to 039edb5 Compare May 31, 2024 20:02
@rzvxa rzvxa force-pushed the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch from 53f497d to 669e1ed Compare May 31, 2024 20:02
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 039edb5 to 2eaa64f Compare May 31, 2024 20:06
@rzvxa rzvxa force-pushed the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch from 669e1ed to f4d764e Compare May 31, 2024 20:06
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 2eaa64f to 70d5a4e Compare May 31, 2024 20:18
@rzvxa rzvxa force-pushed the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch from f4d764e to 478aad3 Compare May 31, 2024 20:19
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 70d5a4e to 5f4dbf4 Compare June 1, 2024 23:15
@rzvxa rzvxa force-pushed the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch from 478aad3 to e2c1f68 Compare June 1, 2024 23:15
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 5f4dbf4 to 8c5b603 Compare June 1, 2024 23:20
@rzvxa rzvxa force-pushed the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch from e2c1f68 to 0d68f83 Compare June 1, 2024 23:20
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 8c5b603 to 1541032 Compare June 1, 2024 23:32
@rzvxa rzvxa force-pushed the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch from 0d68f83 to 9aa8f48 Compare June 1, 2024 23:32
@rzvxa rzvxa marked this pull request as ready for review June 4, 2024 14:34
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 1541032 to cade273 Compare June 5, 2024 19:14
@rzvxa rzvxa force-pushed the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch from 9aa8f48 to 94bc8d8 Compare June 5, 2024 19:14
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from cade273 to e1d17b1 Compare June 5, 2024 19:30
@rzvxa rzvxa force-pushed the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch from 94bc8d8 to 3c67f42 Compare June 5, 2024 19:30
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from e1d17b1 to 8b3f50d Compare June 6, 2024 06:04
@rzvxa rzvxa force-pushed the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch from 572e94a to e56665c Compare June 6, 2024 06:04
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 8b3f50d to c958425 Compare June 6, 2024 06:13
@rzvxa rzvxa force-pushed the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch from e56665c to 33826cf Compare June 6, 2024 06:13
@rzvxa rzvxa force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from c958425 to 7860e8a Compare June 6, 2024 06:16
@rzvxa rzvxa force-pushed the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch from 33826cf to 93a23d7 Compare June 6, 2024 06:16
Copy link

graphite-app bot commented Jun 6, 2024

Merge activity

@Boshen Boshen force-pushed the 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ branch from 7860e8a to 987a3f3 Compare June 6, 2024 07:57
@Boshen Boshen force-pushed the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch from 93a23d7 to 60f89d1 Compare June 6, 2024 07:58
@Boshen Boshen changed the base branch from 05-28-improvement_linter_react_use_cfg_for_detecting_cyclic_subgraphs_in_rules-of-hooks_ to main June 6, 2024 08:02
@graphite-app graphite-app bot merged commit 60f89d1 into main Jun 6, 2024
22 checks passed
@graphite-app graphite-app bot deleted the 05-30-improvement_linter_react_use_new_cfg_for_detection_conditional_nodes branch June 6, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant