Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): should parser error when function declaration has no name #3461

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented May 29, 2024

Copy link

graphite-app bot commented May 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-parser Area - Parser label May 29, 2024
Copy link
Member Author

Dunqing commented May 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@Dunqing Dunqing marked this pull request as ready for review May 29, 2024 10:44
Copy link

codspeed-hq bot commented May 29, 2024

CodSpeed Performance Report

Merging #3461 will not alter performance

Comparing 05-29-fix_parser_should_parser_error_when_function_declaration_has_no_name (916d8a7) with main (90b0f6d)

Summary

✅ 22 untouched benchmarks

@Dunqing Dunqing force-pushed the 05-29-fix_parser_should_parser_error_when_function_declaration_has_no_name branch from 65cbfe4 to 7cbab0b Compare May 29, 2024 13:27
@Dunqing Dunqing force-pushed the 05-29-fix_parser_should_parser_error_when_function_declaration_has_no_name branch from 7cbab0b to 916d8a7 Compare May 29, 2024 13:42
@github-actions github-actions bot added the A-linter Area - Linter label May 29, 2024
@Boshen Boshen merged commit 350cd91 into main May 30, 2024
25 checks passed
@Boshen Boshen deleted the 05-29-fix_parser_should_parser_error_when_function_declaration_has_no_name branch May 30, 2024 11:58
Boshen added a commit that referenced this pull request Jun 7, 2024
## [0.4.3] - 2024-06-07

### Features

- 1fb9d23 linter: Add fixer for no-useless-fallback-in-spread rule
(#3544) (Don Isaac)
- 6506d08 linter: Add fixer for no-single-promise-in-promise-methods
(#3531) (Don Isaac)
- daf559f linter: Eslint-plugin-jest/no-large-snapshot (#3436) (cinchen)
- 4c17bc6 linter: Eslint/no-constructor-return (#3321) (谭光志)
- 4a075cc linter/jsdoc: Implement require-param rule (#3554) (Yuji
Sugiura)
- 747500a linter/jsdoc: Implement require-returns-type rule (#3458)
(Yuji Sugiura)
- 6b39654 linter/tree-shaking: Support options (#3504) (Wang Wenzhe)
- 0cdb45a oxc_codegen: Preserve annotate comment (#3465)
(IWANABETHATGUY)

### Bug Fixes

- b188778 linter/eslint: Fix `require-await` false positives in
`ForOfStatement`. (#3457) (rzvxa)
- 350cd91 parser: Should parser error when function declaration has no
name (#3461) (Dunqing)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter A-parser Area - Parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants