Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oxc_codegen): preserve annotate comment #3465

Merged

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented May 29, 2024

  1. Copy tests from https://github.com/evanw/esbuild/blob/efa3dd2d8e895f7f9a9bef0d588560bbae7d776e/internal/bundler_tests/bundler_dce_test.go#L3833-L3971
  2. Add option to preserve annotate comment like /* #__NO_SIDE_EFFECTS__ */ and /* #__PURE__ */

@github-actions github-actions bot added A-linter Area - Linter A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation labels May 29, 2024
Copy link

graphite-app bot commented May 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented May 29, 2024

CodSpeed Performance Report

Merging #3465 will not alter performance

Comparing IWANABETHATGUY:feat/preserve-annotate-comment1 (f556a60) with main (ec041a0)

Summary

✅ 22 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/preserve-annotate-comment1 branch from 531100f to 3aca9f5 Compare May 29, 2024 16:25
@IWANABETHATGUY IWANABETHATGUY changed the title feat: 🎸 preserve annotate comment feat: preserve annotate comment May 29, 2024
@IWANABETHATGUY IWANABETHATGUY changed the title feat: preserve annotate comment feat(oxc_codegen): preserve annotate comment May 29, 2024
@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/preserve-annotate-comment1 branch from 3aca9f5 to 4586bb4 Compare May 29, 2024 16:52
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review May 29, 2024 18:14
@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/preserve-annotate-comment1 branch from 0fe3ac9 to f556a60 Compare May 30, 2024 03:17
@IWANABETHATGUY IWANABETHATGUY enabled auto-merge (squash) May 30, 2024 06:12
@IWANABETHATGUY IWANABETHATGUY merged commit 0cdb45a into oxc-project:main May 30, 2024
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the feat/preserve-annotate-comment1 branch May 30, 2024 12:14
Boshen added a commit that referenced this pull request Jun 7, 2024
## [0.4.3] - 2024-06-07

### Features

- 1fb9d23 linter: Add fixer for no-useless-fallback-in-spread rule
(#3544) (Don Isaac)
- 6506d08 linter: Add fixer for no-single-promise-in-promise-methods
(#3531) (Don Isaac)
- daf559f linter: Eslint-plugin-jest/no-large-snapshot (#3436) (cinchen)
- 4c17bc6 linter: Eslint/no-constructor-return (#3321) (谭光志)
- 4a075cc linter/jsdoc: Implement require-param rule (#3554) (Yuji
Sugiura)
- 747500a linter/jsdoc: Implement require-returns-type rule (#3458)
(Yuji Sugiura)
- 6b39654 linter/tree-shaking: Support options (#3504) (Wang Wenzhe)
- 0cdb45a oxc_codegen: Preserve annotate comment (#3465)
(IWANABETHATGUY)

### Bug Fixes

- b188778 linter/eslint: Fix `require-await` false positives in
`ForOfStatement`. (#3457) (rzvxa)
- 350cd91 parser: Should parser error when function declaration has no
name (#3461) (Dunqing)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area - Code Generation A-linter Area - Linter A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants