fix(ast): put decorators before everything else.
#4143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-parser
rzvxa
changed the title
decorators.decorators.
rzvxa
changed the title
decorators.decorators before everything else.
rzvxa
changed the title
decorators before everything else.decorators before everything else.
CodSpeed Performance ReportMerging #4143 will not alter performanceComparing Summary
|
overlookmotel
approved these changes
Jul 10, 2024
|
LOVE the fact that we don't need to touch all the boilerplate code anymore, it wasn't even possible last week. |
Merge activity
|
Won't fix #4142 It is similar to #3994 but for those types that weren't relying on this order. It seems to be the right order. technically speaking it is a breaking change but I know as a fact that it won't have a big difference on our downstream. If you want it to be chronically correct feel free to merge as a breaking change.
Boshen
force-pushed
the
07-09-fix_reorder_every_instance_of_decorators_
branch
from
a536cf5
to
48947a2
Compare
graphite-app
bot
deleted the
07-09-fix_reorder_every_instance_of_decorators_
branch
Merged
Boshen
added a commit
that referenced
this pull request
Jul 11, 2024
## [0.20.0] - 2024-07-11 - 5731e39 ast: [**BREAKING**] Store span details inside comment struct (#4132) (Luca Bruno) ### Features - 67fe75e ast, ast_codegen: Pass the `scope_id` to the `enter_scope` event. (#4168) (rzvxa) - 54cd04a minifier: Implement dce with var hoisting (#4160) (Boshen) - 44a894a minifier: Implement return statement dce (#4155) (Boshen) - 725571a napi/transformer: Add `jsx` option to force parsing with jsx (#4133) (Boshen) ### Bug Fixes - 48947a2 ast: Put `decorators` before everything else. (#4143) (rzvxa) - 7a059ab cfg: Double resolution of labeled statements. (#4177) (rzvxa) - 4a656c3 lexer: Incorrect lexing of large hex/octal/binary literals (#4072) (DonIsaac) - 28eeee0 parser: Fix asi error diagnostic pointing at invalid text causing crash (#4163) (Boshen) ### Performance - ddfa343 diagnostic: Use `Cow<'static, str>` over `String` (#4175) (DonIsaac) - 2203143 semantic: Store unresolved refs in a stack (#4162) (lucab) - fca9706 semantic: Faster search for leading comments (#4140) (Boshen) ### Documentation - bdcc298 ast: Update the note regarding the `ast_codegen` markers. (#4149) (rzvxa) ### Refactor - 03ad1e3 semantic: Tweak comment argument type (#4157) (lucab) Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Won't fix #4142
It is similar to #3994 but for those types that weren't relying on this order. It seems to be the right order.
technically speaking it is a breaking change but I know as a fact that it won't have a big difference on our downstream. If you want it to be chronically correct feel free to merge as a breaking change.