Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ast): update the note regarding the ast_codegen markers. #4149

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented Jul 9, 2024

No description provided.

Copy link

graphite-app bot commented Jul 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-ast Area - AST label Jul 9, 2024
Copy link
Collaborator Author

rzvxa commented Jul 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@rzvxa rzvxa marked this pull request as ready for review July 9, 2024 22:49
@rzvxa rzvxa added the merge label Jul 9, 2024
Copy link

graphite-app bot commented Jul 9, 2024

Merge activity

  • Jul 9, 6:49 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 9, 6:55 PM EDT: rzvxa merged this pull request with the Graphite merge queue.

@rzvxa rzvxa force-pushed the 07-10-docs_ast_update_the_note_regarding_the_ast_codegen_markers branch from 0a22284 to bdcc298 Compare July 9, 2024 22:52
@graphite-app graphite-app bot merged commit bdcc298 into main Jul 9, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 07-10-docs_ast_update_the_note_regarding_the_ast_codegen_markers branch July 9, 2024 22:55
Copy link

codspeed-hq bot commented Jul 9, 2024

CodSpeed Performance Report

Merging #4149 will not alter performance

Comparing 07-10-docs_ast_update_the_note_regarding_the_ast_codegen_markers (bdcc298) with main (5731e39)

Summary

✅ 29 untouched benchmarks

@github-actions github-actions bot mentioned this pull request Jul 11, 2024
Boshen added a commit that referenced this pull request Jul 11, 2024
## [0.20.0] - 2024-07-11

- 5731e39 ast: [**BREAKING**] Store span details inside comment struct
(#4132) (Luca Bruno)

### Features

- 67fe75e ast, ast_codegen: Pass the `scope_id` to the `enter_scope`
event. (#4168) (rzvxa)
- 54cd04a minifier: Implement dce with var hoisting (#4160) (Boshen)
- 44a894a minifier: Implement return statement dce (#4155) (Boshen)
- 725571a napi/transformer: Add `jsx` option to force parsing with jsx
(#4133) (Boshen)

### Bug Fixes

- 48947a2 ast: Put `decorators` before everything else. (#4143) (rzvxa)
- 7a059ab cfg: Double resolution of labeled statements. (#4177) (rzvxa)
- 4a656c3 lexer: Incorrect lexing of large hex/octal/binary literals
(#4072) (DonIsaac)
- 28eeee0 parser: Fix asi error diagnostic pointing at invalid text
causing crash (#4163) (Boshen)

### Performance

- ddfa343 diagnostic: Use `Cow<'static, str>` over `String` (#4175)
(DonIsaac)
- 2203143 semantic: Store unresolved refs in a stack (#4162) (lucab)
- fca9706 semantic: Faster search for leading comments (#4140) (Boshen)

### Documentation

- bdcc298 ast: Update the note regarding the `ast_codegen` markers.
(#4149) (rzvxa)

### Refactor

- 03ad1e3 semantic: Tweak comment argument type (#4157) (lucab)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant