fix(rulegen): handle join('\n') style test code #763
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Support join('\n')
I'm trying to run
just new-rule no-unexpected-multiline
, It found rulegen not support test code pieced together usingarray.json("\n")
, likeI found this kind of code widely in the eslint codebase, so it will be great if we can support this.
2. remove extra
,
And I found when meet unsupported code, rulegen will generate an extra
,
, so I added a filter athttps://github.com/web-infra-dev/oxc/blob/45cf5fc3da04be07e2293ad1a8dc77b8690f1e9f/tasks/rulegen/src/main.rs#L363
3. handle escape string
The escape
/
and trailing/
in the javascript code will break rulegen. example:"\"abc\\\n(123)\""
I made the following changes: