Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(benchmark): turn on all lints #892

Merged
merged 1 commit into from
Sep 10, 2023
Merged

chore(benchmark): turn on all lints #892

merged 1 commit into from
Sep 10, 2023

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Sep 10, 2023

closes #888

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 10, 2023

CodSpeed Performance Report

Merging #892 will degrade performances by 51.41%

Comparing bench-all-lints (f22fb06) with main (7a9f821)

Summary

❌ 4 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bench-all-lints Change
❌ linter[react.development.js] 46.3 ms 95.4 ms -51.41%
❌ linter[vue.js] 311.3 ms 516.8 ms -39.77%
❌ linter[antd.js] 3.7 s 5.9 s -37.09%
❌ linter[typescript.js] 6.7 s 10.8 s -37.86%

@Boshen Boshen merged commit a9d36f1 into main Sep 10, 2023
17 of 18 checks passed
@Boshen Boshen deleted the bench-all-lints branch September 10, 2023 15:16
eryue0220 added a commit to eryue0220/oxc that referenced this pull request Sep 11, 2023
@eryue0220
Merge branch 'feat/no-redeclare' of github.com:eryue0220/oxc into fea…
5e195e9 
…t/no-redeclare

* 'feat/no-redeclare' of github.com:eryue0220/oxc: (22 commits)
  deps: remove default-features from codspeed-criterion-compat
  chore(deps): bump the dependencies group with 4 updates (oxc-project#893)
  chore(deps): bump actions/checkout from 3 to 4 (oxc-project#894)
  feat(minifier): constant addition expression folding (oxc-project#882)
  chore(benchmark): turn on all lints (oxc-project#892)
  feat(linter): eslint-plugin-import(no-cycle) (oxc-project#890)
  chore: fix typo (oxc-project#889)
  perf(linter): early bail out if not jest fn (oxc-project#885)
  feat(linter): add typescript/no-explicit-any (oxc-project#881)
  feat(website): Hide error panel when query view is shown (oxc-project#884)
  fix(website): fix run_query call arguments (oxc-project#880)
  feat(linter): eslint-plugin-import/no-self-import (oxc-project#878)
  feat(linter): implement re-exports (oxc-project#877)
  ci(benchmark): install toolchain first
  refactor(resolver): clean up `load_alias` (oxc-project#875)
  fix(parser): parse [+In] in object binding initializer (oxc-project#874)
  chore(fuzz): add --sanitizer none command
  chore(fuzz): add nightly instructions
  refactor: clean up fuzzer, move it to repo root (oxc-project#872)
  perf(resolver): avoid double hashing by memoizing the hash (oxc-project#871)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

turn on all lints for the linter benchmark
1 participant
@Boshen