Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): eslint-plugin-import(no-cycle) #890

Merged
merged 1 commit into from
Sep 10, 2023
Merged

feat(linter): eslint-plugin-import(no-cycle) #890

merged 1 commit into from
Sep 10, 2023

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Sep 10, 2023 •
edited
Loading

closes #879

@github-actions github-actions bot added the A-linter Area - Linter label Sep 10, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 10, 2023

CodSpeed Performance Report

Merging #890 will not alter performance

Comparing no-cycle (34e40fa) with main (7a9f821)

Summary

✅ 18 untouched benchmarks

mysteryven
mysteryven approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@mysteryven mysteryven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so elegant, I love this implementation, it's totally another style compared with other ESLint plugins!

@mysteryven mysteryven merged commit f488e1f into main Sep 10, 2023
16 checks passed
@mysteryven mysteryven deleted the no-cycle branch September 10, 2023 14:58
eryue0220 added a commit to eryue0220/oxc that referenced this pull request Sep 11, 2023
@eryue0220
Merge branch 'feat/no-redeclare' of github.com:eryue0220/oxc into fea…
5e195e9 
…t/no-redeclare

* 'feat/no-redeclare' of github.com:eryue0220/oxc: (22 commits)
  deps: remove default-features from codspeed-criterion-compat
  chore(deps): bump the dependencies group with 4 updates (oxc-project#893)
  chore(deps): bump actions/checkout from 3 to 4 (oxc-project#894)
  feat(minifier): constant addition expression folding (oxc-project#882)
  chore(benchmark): turn on all lints (oxc-project#892)
  feat(linter): eslint-plugin-import(no-cycle) (oxc-project#890)
  chore: fix typo (oxc-project#889)
  perf(linter): early bail out if not jest fn (oxc-project#885)
  feat(linter): add typescript/no-explicit-any (oxc-project#881)
  feat(website): Hide error panel when query view is shown (oxc-project#884)
  fix(website): fix run_query call arguments (oxc-project#880)
  feat(linter): eslint-plugin-import/no-self-import (oxc-project#878)
  feat(linter): implement re-exports (oxc-project#877)
  ci(benchmark): install toolchain first
  refactor(resolver): clean up `load_alias` (oxc-project#875)
  fix(parser): parse [+In] in object binding initializer (oxc-project#874)
  chore(fuzz): add --sanitizer none command
  chore(fuzz): add nightly instructions
  refactor: clean up fuzzer, move it to repo root (oxc-project#872)
  perf(resolver): avoid double hashing by memoizing the hash (oxc-project#871)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysteryven mysteryven mysteryven approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(linter): eslint-plugin-import/no-cycle
2 participants
@Boshen @mysteryven