Added new function to call canvas service 'List submissions for multiple assignments' from the Submission API #45
Conversation
|
Hi @buckett, hope you're doing ok. EDF is working on some LTI tool integrated with Canvas using this library and @Elonso95 has noticed some missing methods/fields. We've told him how to proceed, so he has followed the existing development patterns to make the updates. I think he has added unit tests where existing. Please review them (#46 is the other one) when you have some time and let us know whatever he has to change to get these merged. Thanks a lot and regards. |
|
|
||
| /** | ||
| * Filter the list of submissions by the given student ids.. | ||
| * @param ids List of ids to filter submissions by | ||
| * @return This object to allow adding more options | ||
| */ | ||
| public GetSubmissionsOptions studentIds(List<String> ids) { | ||
| optionsMap.put("student_ids[]", ids); | ||
| return this; | ||
| } |
There was a problem hiding this comment.
Putting this in a class called GetMultipleSubmissionsOptions would make more sense as the two calls take very different arguments and normally the Options objects have constructors that take all the required arguments.
https://canvas.instructure.com/doc/api/submissions.html#method.submissions_api.index
https://canvas.instructure.com/doc/api/submissions.html#method.submissions_api.for_students
| @@ -62,6 +62,16 @@ public SubmissionImpl(String canvasBaseUrl, Integer apiVersion, OauthToken oauth | |||
| final String url = buildCanvasUrl(String.format("sections/%s/assignments/%d/submissions", options.getCanvasId(), options.getAssignmentId()), options.getOptionsMap()); | |||
| return getListFromCanvas(url); | |||
| } | |||
|
|
|||
| @Override | |||
| public List<Submission> getCourseSubmissionMultipleAssignments(final GetSubmissionsOptions options) throws IOException { | |||
There was a problem hiding this comment.
I think this should probably take a GetMultipleSubmissionsOptions object.
Elonso95
force-pushed
the
retrieve_multiple_assignment_submissions
branch
2 times, most recently
from
4b823ad
to
757b27d
Compare
Elonso95
force-pushed
the
retrieve_multiple_assignment_submissions
branch
from
757b27d
to
a055dbc
Compare
|
Hi @buckett. We solved the problem in the tests that prevented the maven build. Hope everything now works! |
Thanks, getting closer, it's just failing on the JavaDoc generation. |
…ple assignments' fron the Submission API
Elonso95
force-pushed
the
retrieve_multiple_assignment_submissions
branch
from
a055dbc
to
703e166
Compare
|
Thanks @buckett now it all seems correct! |
|
Thanks. |
|
Hi @buckett , this was the last update of the library we needed for our current project. Would it be possible to release a new version when possible? Thanks a lot, much appreciated. |
|
Brill! Thanks again |
No description provided.