Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added attributes 'private' and 'suscribed' to the CreateConversationOptions model #46

Closed

Conversation

Elonso95
Copy link

No description provided.

Copy link
Member

@buckett buckett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

I had a look at: https://canvas.instructure.com/doc/api/conversations.html#method.conversations.create and neither private or subscribed look to be options you can supply when creating a new conversation, just fields that are returned about an existing conversation.

@Elonso95
Copy link
Author

You are right @buckett.
I took the example from a client that was using them as parameters for creating a conversation but it seems they are not needed for it to work.
With that I am closing this pull request.

@Elonso95 Elonso95 closed this Mar 25, 2022
@Elonso95 Elonso95 deleted the attributes_create_conversation_options branch March 25, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants