Update multiple courses method #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgarciaentornos
force-pushed
the
updateCourses
branch
from
a119b60
to
dbf5da8
Compare
buckett
reviewed
Apr 8, 2022
Comment on lines
38
to
41
| public UpdateCoursesOptions courseIds(List<Integer> courseIds) { | ||
| addNumberList("course_ids[]", courseIds); | ||
| return this; | ||
| } |
There was a problem hiding this comment.
Normally I would expect this to accept String rather than a number so that you can use SIS IDs as well as Canvas course IDs (https://canvas.instructure.com/doc/api/file.object_ids.html).
If it doesn't support SIS ID expansion then it should at least be Long as all numbers in the Canvas API (for IDs) are 64 bit.
bgarciaentornos
force-pushed
the
updateCourses
branch
from
dbf5da8
to
e46b644
Compare
|
Done, thanks! |
buckett
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://canvas.instructure.com/doc/api/courses.html#method.courses.batch_update