-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS system extension #1942
macOS system extension #1942
Conversation
43741aa
to
76d30e5
Compare
* add --start flag to start lokinet * add --stop flag to stop * by default lokinet on macos needs a flag or it will be a nop
Make the mac build require passing either an explicit -DCODESIGN=OFF or the code signing identities.
Otherwise cmake warns about propagation of normal variables into cache variables when it hits the option in the oxen-mq submodule.
…at does not have a route spec for the interace ip on loopback as apple finds having sensible defaults bothersome internally
Now works. Relies on oxen-io/lokinet-gui#17 |
We have a new mac icon (added as an svg here and built during the build), but it still requires some tweaks (that can come in a separate PR though). |
The way this now works is the following. It is dumb, but this is macos and apparently that's how Apple wants it to be.
|
Adds support for building Lokinet as a system extension, and fixes various problems in the macos implementation found during development of the system extension support.
Apple's servers have a gateway timeout a small but noticeable percentage of the time, which was breaking the script. Detect such Apple flakiness and keep trying.
The one we were applying for closesocket breaks on some versions.
It's easy enough to add -DSUBMODULE_CHECK=OFF yourself if you really won't want it, and much more useful to have it enabled as a default.
This adds the gui as a submodule, and consolidates the GUI handling a bit between the two platforms.
This avoids needing to build it and include it in static builds since we aren't currently making use of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the cmake ponderings this looks good to merge
Still needs: