Add SafeViewPager to fix touch exception in MediaPreviewActivity #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bemusementpark
force-pushed
the
fix-media-touch-exception
branch
from
08a28bf
to
452e26b
Compare
bemusementpark
force-pushed
the
fix-media-touch-exception
branch
from
452e26b
to
203fbeb
Compare
Merged
burtonemily
pushed a commit
to burtonemily/session-android
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
ViewPagerdoesn't behave well with zoom and scale gesture detection in its child views.SafeViewPagercatches and ignores exceptions thrown whenViewPagerwould retrieve position of stale or non-existent touches.We could have alternatively used
ViewPager2orRecyclerViewbut that would be an extensive refactor and may involve refactoringCursorAdapters to beRecyclerView.Adapters.