Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase voice recording limit to 5m #1201

Merged

Conversation

steveej
Copy link

@steveej steveej commented May 18, 2023

First time contributor checklist

Contributor checklist

  • I have tested my contribution on these devices:
  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

i just took a sample on android and i got 257KiB from a 55s long recording.
this would mean we could actually record 431s (1.97 * 1024/(257/55 * 60) * 60) before the file exceeds 1.97MiB. this assumes a constant bitrate and i'm not sure that's realistic. it seems realistic to assume that upping the duration limit to 5 minutes on session-android would not exceed the 1.97MiB that seem applied on session-desktop.

fixes #1182.

@KeeJef
Copy link
Collaborator

KeeJef commented May 23, 2023

Just a few quick questions on this

Could we clarify if a voice recording, with a duration of five minutes created on an Android device, will always be within the 10MB limit? Do different devices / or voice recordings produce different file sizes which could exceed this limit?

Additionally, do we foresee any compatibility issues with other platforms such as iOS and Desktop? Could there be any difficulties interpreting, displaying, or playing back these 5-minute voice messages on these platforms?

@steveej
Copy link
Author

steveej commented May 23, 2023

@KeeJef

i explored that in #1182 (comment) which i just copied to the original comment.

@KeeJef
Copy link
Collaborator

KeeJef commented Jul 3, 2023

@hjubb if Session is using a fixed bittrate to record messages then this should be fine to merge whenever we want

@hjubb hjubb changed the base branch from master to dev July 3, 2023 01:42
@hjubb hjubb merged commit ba4143c into oxen-io:dev Jul 3, 2023
@steveej steveej deleted the feat_increase_voicerecording_limit branch July 3, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Longer voice messages (up to 10 minutes)
3 participants