Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility tags v2 #1218

Closed
wants to merge 2 commits into from

Conversation

burtonemily
Copy link
Collaborator

First time contributor checklist

Contributor checklist

  • I have tested my contribution on these devices:
  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

@hjubb
Copy link

hjubb commented Jun 19, 2023

Could you change the base of this PR to dev @burtonemily so it doesn't show commits that aren't in master yet? I think it's pulling in pending dev release stuff

@burtonemily
Copy link
Collaborator Author

@hjubb ah shit sorry! Not sure what I did there..

@hjubb
Copy link

hjubb commented Jun 20, 2023

All good 😄 I think it's the default as a target, but it'll just exclude the unreleased changes if you compare against dev instead 👍

@hjubb hjubb changed the base branch from master to dev June 20, 2023 07:37
@burtonemily burtonemily closed this Aug 1, 2023
@burtonemily burtonemily deleted the accessibility-tags-v2 branch August 1, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants