Add leave open group button in conversation #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceokot
approved these changes
Sep 13, 2022
|
Whats the status on this? |
|
we can probably merge this one in, just held off for release because it wasn't tied to any particular current issue so didn't want to introduce anything that might cause an issue if it wasn't necessary |
bemusementpark
approved these changes
Jun 6, 2023
|
|
||
| val builder = AlertDialog.Builder(this) | ||
| .setTitle(R.string.ConversationActivity_leave_group) | ||
| .setCancelable(true) |
There was a problem hiding this comment.
cancelable(true) is the default. delete.
| if (threadId == -1L) return@setPositiveButton | ||
| val v2OpenGroup = DatabaseComponent.get(this).lokiThreadDatabase().getOpenGroupChat(threadId) ?: return@setPositiveButton | ||
| OpenGroupManager.delete(v2OpenGroup.server, v2OpenGroup.room, this) | ||
| finish() |
There was a problem hiding this comment.
could do something like this to remove the return@s if you want.
DatabaseComponent.get(this).threadDatabase().getThreadIdIfExistsFor(thread)
?.takeIf { it != -1L }
?.let { DatabaseComponent.get(this).lokiThreadDatabase().getOpenGroupChat(it) }
?.apply {
OpenGroupManager.delete(server, room, this)
finish()
}
}
|
My understanding is that this task needs to be completed as part of post-release chunk 1. We might want to cherrypick this when the time comes, or simply close it and redo it when we start working on that chunk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.