Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Enter password only once #1768

Closed
144 opened this issue Jul 4, 2021 · 4 comments
Closed

Suggestion: Enter password only once #1768

144 opened this issue Jul 4, 2021 · 4 comments
Labels
Clientside Security Clientside security features enhancement New feature or request good first issue Good for newcomers

Comments

@144
Copy link

144 commented Jul 4, 2021

Having to enter password 2 times is kinda annoying, first to open the app and second time when you want to change/view something in the settings.

image
@144 144 changed the title Enter password only once Suggestion: Enter password only once Jul 4, 2021
@KeeJef KeeJef added Clientside Security Clientside security features enhancement New feature or request labels Jul 5, 2021
@Bilb
Copy link
Collaborator

Bilb commented Apr 14, 2022

well, this is to make sure someone doesn't come and grab your recovery phrase nor change your settings while you are away.
@KeeJef do we want to just ask for it when showing the recovery phrase instead and change/delete the password?

@KeeJef
Copy link
Collaborator

KeeJef commented Apr 15, 2022

Yeah settings probably don't need to be behind a password prompt, i think this should just be for showing the recovery phrase

@KeeJef KeeJef added the good first issue Good for newcomers label Feb 3, 2023
@Bilb
Copy link
Collaborator

Bilb commented Feb 14, 2023

Easy enough then. We just want it for the login screen and the recovery phrase dialog

KeeJef pushed a commit to KeeJef/session-desktop that referenced this issue Oct 9, 2023
@KeeJef
feat: remove app setting password protection
2f6bf2e 
Most app settings are less sensitive
than the content of one's messages,
and therefore do not require password protection.

This commit removes password protection from
the settings view. This also dampens the UX impact
of the misleading 'Message Requests' entry among
settings categories, as the settings view
is closed and locked upon navigation to the entry.

Sensitive app settings are addressed in later commits.

Relates: oxen-io#1768
@KeeJef KeeJef mentioned this issue Oct 9, 2023
Closed
@Bilb Bilb mentioned this issue Mar 26, 2024
Merged
@Bilb Bilb closed this as completed Mar 26, 2024
@Bilb
Copy link
Collaborator

Bilb commented Mar 26, 2024

closed in favor of #3059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clientside Security Clientside security features enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Bilb @144 @KeeJef