feat: remove app setting password protection #2954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 9, 2023 19:38
Most app settings are less sensitive than the content of one's messages, and therefore do not require password protection. This commit removes password protection from the settings view. This also dampens the UX impact of the misleading 'Message Requests' entry among settings categories, as the settings view is closed and locked upon navigation to the entry. Sensitive app settings are addressed in later commits. Relates: oxen-io#1768
As we may want to password-protect other settings categories, it is crucial to seperate the password protection modal from the seed phrase modal, where it was previously bound.
|
closed in favor of #3059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a proxy pull request from the following codeberg branch https://codeberg.org/gravel/session-desktop/commits/branch/no-protect-settings
Relates: #1768