Update minimum height to 600px #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilb
approved these changes
May 27, 2020
|
Does it ensure these are still clickable (for integration tests and otherwise?) |
vincentbavitz
approved these changes
May 27, 2020
Yup they should be as we still use I'll double check that it works on integration tests. Edit: Integration tests still work |
|
Found a small UI bug which i'll fix and then merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the minimum height and fixes UI elements to allow scrolling. This should help our users who use a lower screen display. The minimum width is still 880px but i couldn't lower that without making significant changes to the UI/UX.
In practice the min height is about 570px, i don't know why but it still works.
Resolves #1131
Resolves #820